-
Notifications
You must be signed in to change notification settings - Fork 58
Add support for HTTP headers #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to support chunks in python3 as the `read()` interface does that for us. Furthermore, this improves fetch performance in large queries (c.f. DinoTools#111). Signed-off-by: Frank Villaro-Dixon <frank@villaro-dixon.eu>
It is useful to be able to specify additional headers to send when making overpass requests. For example a special user agent, or an API token. Signed-off-by: Frank Villaro-Dixon <frank@villaro-dixon.eu>
As customary with API libraries, it is useful for server operators to know which library makes requests to it. This sets the default to the library + version. Signed-off-by: Frank Villaro-Dixon <frank@villaro-dixon.eu>
@Frankkkkk
Frankkkkk
force-pushed
the
fvd-headers
branch
from
May 7, 2024 07:43
ba6a61d to
8829d9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue type
Summary
Hi,
This introduces 2 main changes:
Thanks for the lib and have a nice week!
Cheers