-
Notifications
You must be signed in to change notification settings - Fork 26
[DRAFT][WIP] Feature/unigetui package broker#1797
Draft
Vladyslav Nikonov (vnikonov-devolutions) wants to merge 20 commits into
Draft
[DRAFT][WIP] Feature/unigetui package broker #1797Vladyslav Nikonov (vnikonov-devolutions) wants to merge 20 commits into
Vladyslav Nikonov (vnikonov-devolutions) wants to merge 20 commits into
Conversation
Implements the UniGetUI package broker protocol: - Policy evaluation engine matching the spec in UniGetUI policies/ - WinGet command-line builder from validated request fields - HTTP/1.1 server over named pipe transport (Windows) - Dry-run executor for testing, real executor for production - Standalone test binary for development without the full agent service The broker validates requests against admin-authored policies before constructing elevated package manager commands. It never executes client-supplied command text directly. Supported: WinGet install/update/uninstall operations. Other managers return 'not supported' for now.
Let maintainers know that an action is required on their side
-
Add the label release-required
Please cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module) when you request a maintainer to cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module) -
Add the label release-blocker
Follow-up is required before cutting a new release if a follow-up is required before cutting a new release -
Add the label publish-required
Please publish libraries (`Devolutions.Gateway.Utils`, OpenAPI clients, etc) when you request a maintainer to publish libraries (Devolutions.Gateway.Utils, OpenAPI clients, etc.) -
Add the label publish-blocker
Follow-up is required before publishing libraries if a follow-up is required before publishing libraries
Refactor the broker HTTP server from raw hyper to axum + aide served over the named pipe (matching the PEDM pattern), preserving all behavior: header validation, audit mode, policy validity window, the kill/pre/main/post execution plan, operation tracker, media types and status codes. server::openapi() emits an OpenAPI 3.1 document from the existing schemars schemas (no duplication), and injects PolicyDocument as a component so the generated C# client also gets strongly-typed policy models. Wire the broker into tools/generate-openapi (target "unigetui-broker") and add crates/unigetui-broker/openapi/ with the committed spec and the C# generator config mirroring PEDM (openapi-generator-cli csharp, httpclient). Generating the C# client itself requires a JRE (openapi-generator-cli is a Java tool); run openapi/generate_all.ps1 on a machine with Java. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Implements UniGetUI package broker (Also see UniGetUI WIP branch Devolutions/UniGetUI#4826)
This is still in early DRAFT, but can be compiled/tested for further development.
Implemented
winget; needs refining but implements most of the functionalityNot implemented yet
wingetSteps to run this branch:
"PackageBroker":{"Enabled":true, "PolicyPath": "C:/path/to/policy.json"}UseAgentBrokerfile at%LOCALAPPDATA%/UniGetUI/Configuration(UniGetUI uses file-based config)