-
-
Notifications
You must be signed in to change notification settings - Fork 111
fix look command offthread_repeat math and mounted rotation - #2836
fix look command offthread_repeat math and mounted rotation #2836BehrRiley wants to merge 6 commits into
offthread_repeat math and mounted rotation #2836Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can clean up FQN for these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Newline after each }.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can make this else if (entity.isPlayer)) { and shift the below sections over.
- refactor LookCommand `FQN`s and control flow - format brackets and remove `FQN`s in `LookCommand`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(minor format) bunch of stray newlines in here
BehrRiley
commented
Sep 3, 2026
this now also resolves (skullfurious) Smooth teleport doesn't seem to work properly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Early continue would look better rather than nesting.
Summary
This update resolves two distinct issues with the look command:
Problem
offthread_repeatargument applied the total relative yaw and pitch repeatedly instead of splitting them into fractional step incrementsRETAIN_VEHICLEand tightened teleport and rotation restrictions, causing mounted entities and players to fail look updatesSolution
offthread_repeatsplits the relative yaw and pitch into fractional step increments instead of repeatedly applying the total distanceTesting, References: