-
-
Notifications
You must be signed in to change notification settings - Fork 111
Moved 8 entity types from EntityTag.color to EntityTag.variant - #2817
Moved 8 entity types from EntityTag.color to EntityTag.variant #2817MC-Samuel wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should obey the includeDeprecated param (as the backsupport is only for tag usage, not property output).
But, it would also be good to provide the warnings with the TagContext - I would say replace the includeDeprecated param with a nullable TagContext and then base it on that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think most of these actually are just enums? Can use the normal Mechanism#requireEnum logic for those
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can probably be a static tag
...changed getColor to take an attribute and fire deprecation message if attribute is not null
Part 1 of moving some entity variants/types/colors from
EntityTag.colortoEntityTag.variant. The goal is to have EntityTag.color as primarily a DyeColor or ColorTag input rather than the current mix of DyeColors, ColorTags, ElementTags, and ListTags.Also added
EntityTag.allowed_variantsto show what variants an entity can be.