-
Notifications
You must be signed in to change notification settings - Fork 3
Comments
Draft
Conversation
@GeoWill
GeoWill
force-pushed
the
WiP-pollingstations-refactor
branch
2 times, most recently
from
June 14, 2021 11:30
693ffb8 to
d6a29c3
Compare
Our current scraping model deals with all the stations and all the districts, so for now I'm just going to reimplement that here. If there's some advantage to scraping individual stations/districts that can be handled down the line.
@GeoWill
GeoWill
force-pushed
the
WiP-pollingstations-refactor
branch
from
June 14, 2021 11:34
d6a29c3 to
e8d89c0
Compare
symroe
symroe
reviewed
Jun 14, 2021
from lgsf.path_utils import load_scraper, load_council_info
class Command(PerCouncilCommandBase):
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feels like a large chunk of this file could be refactored in to a common file - it's largely the same as the councillors one, and it would be good to keep the outputs and interfaces as similar as we can I think.
This can be an issue of course, not needed for this PR
from lgsf.polling_stations.scrapers.xml_scrapers import GmlScraper
class Scraper(GmlScraper):
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, I think this is really nice and readable. Not convinced that having two classes (PollingScraper and DistrictsScraper) would be any easier for a developer to work on. There might be other reasons to have them of course.
@GeoWill
GeoWill
force-pushed
the
WiP-pollingstations-refactor
branch
from
June 15, 2021 08:12
52f858f to
60c43df
Compare
Merged
@symroe
symroe
force-pushed
the
master
branch
from
November 27, 2022 15:17
4f7f5f9 to
bde66b7
Compare
@symroe
symroe
force-pushed
the
master
branch
2 times, most recently
from
June 24, 2025 20:12
7dc5520 to
0cc3fbe
Compare
@symroe
symroe
force-pushed
the
master
branch
7 times, most recently
from
October 25, 2025 09:20
ef3fb0d to
f564c99
Compare
@symroe
symroe
force-pushed
the
master
branch
3 times, most recently
from
November 5, 2025 15:59
1e6bca7 to
b6d2c5f
Compare
@symroe
symroe
force-pushed
the
master
branch
from
November 5, 2025 16:15
b6d2c5f to
29c971d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Port of https://github.com/wdiv-scrapers/dc-base-scrapers
Rational is to only have maintain one set of tooling/checks/deployment stuff around scraping 'types of thing' from multiple councils.
We will have to do this quite well for the reps work, so we might as well reap the benefits for polling stations - which neede some love anyway.