-
Notifications
You must be signed in to change notification settings - Fork 361
[Op] Implement GPU version of KvResourceSparseApplyAdam. #535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里直接调用AdamAsync的functor吗?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
是的,我注意到AdamAsync的functor中逻辑代码与Adam相同,只是AdamAsync多了apply_sparse_rmsprop参数,于是考虑复用functor逻辑代码,不同在于将Adam 中调用的functor 中apply_sparse_rmsprop 置为了false
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
嗯,我建议新写一个functor::KvSparseApplyAdam,而不是复用这个,避免别人改AdamAsync的functor而影响到这里的逻辑正确性
No description provided.