-
Notifications
You must be signed in to change notification settings - Fork 8
Comments
Conversation
- Release app version after upload #273 Graphite 👈 (View in Graphite)
- Allow passing version name via environmental variable to apps plugin #272 Graphite
master
This stack of pull requests is managed by Graphite. Learn more about stacking.
✅ Tests
🎉 All green!
❄️ No new flaky tests detected
🧪 All tests passed
🔗 Commit SHA: 872da69 | Docs | Datadog PR Page | Was this helpful? Give us feedback!
a83fc18 to
35cda9b
Compare
35cda9b to
78322bb
Compare
78322bb to
872da69
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 872da69279
i️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2 Badge Honor APPS_INTAKE_URL when building release endpoint
getReleaseUrl always targets https://api.<site>/.../release/live, while upload still honors DD_APPS_INTAKE_URL/DATADOG_APPS_INTAKE_URL via getIntakeUrl. In setups that use a custom intake host (proxy, staging, internal gateway), enabling APPS_VERSION_NAME will make the new release call go to a different backend than the upload call, causing release to fail (and the build to error) even though archive upload succeeded.
Useful? React with 👍 / 👎.
Uh oh!
There was an error while loading. Please reload this page.
What and why?
After uploading the built zip archive to Datadog (presumably in a CI environment), also mark that version as the latest released version by making a PUT call to
release/liveMaking this call in the build script was the best possible move because various configs e.g. the Datadog site is configured in the Datadog vite plugin, which would be non-trivial to extract in a CI script and it would be user-unfriendly to have the user configure that again e.g. in the GH action.
How?
Call
/release/liveusingdoRequestafter the application has been uploaded