-
Notifications
You must be signed in to change notification settings - Fork 50
Conversation
KiritoFD
commented
Feb 25, 2026
this has no conflict with the main branch , but if you insist , I will start a new repo.
w568w
commented
Feb 25, 2026
Some general suggestions:
- You may want to exclude cached / temporary files from your repository with
.gitignorefirst, e.g.,harmony/ohos/.hvigor,ohos/{.hvigor.bak,cache,reports},third_party/_local,bm_dump_latest.txt, etc. Then usegit rm --cachedto untrack them and push. You were tracking and committing all of them to the remote repository, which is a bad practice. - This PR renames the Android / iOS package name (e.g., in
android/app/src/main/AndroidManifest.xml), which is a breaking change. Can you explain the reason? - There are many mixed changes in
lib/. Maybe we need to inspect their necessity one by one before deciding whether we want to merge it.
KiritoFD
commented
Apr 26, 2026
built with the OpenHarmony Flutter 3.35 SDK. the adaptation is intentionally non-invasive and build-scoped; added lines are mostly requirements in .vendor
w568w
commented
May 10, 2026
If you feel ready to get it reviewed, please let me know!
KiritoFD
commented
May 10, 2026
If you feel ready to get it reviewed, please let me know!
Yes, it's ready for review.
most of the added files are dependency files (like the .vendor directory) included to keep the HarmonyOS build stable. The core logic remains completely untouched. I can strip these dependencies out if you prefer a cleaner PR diff, though it might complicate the build setup .
@w568w
w568w
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some preliminary findings below.
Also, could you please explain why it requires 6 directories to support HarmonyOS?
Harmony/andohos/look the same thing to me..vendor/and.vendor_ohos/: what are their purposes? To re-package some platform-specific packages?.ohos/: what's the difference fromohos/?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be better removed, or moved to https://github.com/DanXi-Dev/docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to #676, you may want to move these *.ps1 to packaging/.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All docs (especially AI-generated ones) should be excluded from the repo for now. You may want to upload them to https://github.com/DanXi-Dev/docs.
No description provided.