-
Notifications
You must be signed in to change notification settings - Fork 260
Python context menu #684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python context menu #684
Conversation
Hide Anaconda context menu entry on non-python projects DamnWidget#571 Allow to hide .sublime-menu folders sublimehq/sublime_text#1859
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @evandrocoan, just a couple of things.
First:
Why did you add the Context.sublime-menu to the .gitignore file? I don't really understand why the install_context is needed in first place, I guess is just a safety in case that ST3 is closed with the Context file being hidden and to guarantee a known state on initialization but I am not sure about the whole thing.
Second:
Do you think you could get this logic and create a new listener in the listeners sub package?
Hi,
- Because I we need to rename the file
Context.sublime-menuto some else asBase Context.sublime-menu, then onplugin_loaded()we copy it or toContext.sublime-menuorContext.sublime-menu-hidden. So when upgrading the fileContext.sublime-menuwe only need to change theBase Context.sublime-menu. Also, would be a pain with git as both filesContext.sublime-menuandContext.sublime-menu-hiddenare constantly changing their names. We would be a lot of, a) the fine is missing now, b) the file is not missing now. - I think I can, but a better solution would be writing a dedicated package to handle this for all other packages. For now I am short of time, so unless I am really required to write a package as for performance loss due too much threads being created. For example, the other related packages as https://github.com/DamnWidget/anaconda_rust/blob/master/Context.sublime-menu also has the menu entry, so if use them I would need to include this there too, which seems not nice to be doing around.
But perhaps we should just wait Sublime Text core implement this as a built-in feature:
- Allow hiding and disabling of menu items with submenus sublimehq/sublime_text#1859 Allow to hide .sublime-menu folders
DamnWidget
commented
Aug 5, 2017
The thing is this will make ST3 to dynamically reload the Context file giving some kind of log behind in the console, I understand that this solution will work but I think is way too clever and a bit hacky. Maybe is worth just to wait till the right fix come from the ST3 development team.
Uh oh!
There was an error while loading. Please reload this page.
Issue: