Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Interactive extra time #3053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vmcj wants to merge 2 commits into DOMjudge:main from vmcj:interactive_extra_time
Closed

Conversation

Copy link
Member

@vmcj vmcj commented Aug 10, 2025

Mostly as PoC,

I think this is helpful for the current state where interactive problems have overhead.

If we want to do this:

  • I think lib.misc.php can mostly be moved to utils for this
  • I made some things static, I assume this is an improvement but I'm not 100% on the performance gain/impact

@vmcj vmcj force-pushed the interactive_extra_time branch 7 times, most recently from 6f91416 to 594135a Compare August 10, 2025 15:35
vmcj added 2 commits August 10, 2025 17:43
Currently interactive problems need more time due to the pipeline
handling. Other problemtypes shouldn't have such requirements but if
someone has a slower interactor or compare script for some types this
can be helpful.
So we both do this to not have `interactive` as special case and to
provide people with the option due to unforseen setups.
@vmcj vmcj force-pushed the interactive_extra_time branch from 594135a to b668e96 Compare August 10, 2025 15:43
Copy link
Member

@eldering eldering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it best to first discuss how we best address this issue with the interactive validator sometimes requiring a lot of extra wallclock time. Ideally we solve that or just add wallclock extra overhead for interactive problems, not generic (also CPU time) overhead.

A side note: there are some problem color changes in this PR.

@@ -101,8 +101,10 @@
regex: /^[1-9]\d*$/
error_message: A positive number is required.
- name: timelimit_overshoot
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep this separate from timelimit_overshoot. Let's discuss in person?

eldering reacted with thumbs up emoji
@vmcj vmcj closed this Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meisterT meisterT meisterT left review comments

@eldering eldering eldering left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /