-
Notifications
You must be signed in to change notification settings - Fork 278
feat: add submission notification #3018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a migration missing? seen doesn't exist yet, does it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
domjudge/webapp/src/Entity/Judging.php
Lines 118 to 120 in 4398ae5
But this may not be important, because the logic of whether to send notifications does not look at this field, (which is at sendNotification @ domjudge.js)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, this SQL query is the same as the one a user access /api/contests/:cid/judgements, except it filters out entries they have ever seen (it will be marked as seen when they click the submission).
Therefore, it is also feasible to implement it directly on the frontend js instead of adding a function to the /update endpoint.
d6d9118 to
32b9f38
Compare
32b9f38 to
44d7fee
Compare
Related to #2252, just for a POC now.
Lack of testing, and I'm not sure how much impact such a query would have on performance when there are a large number of teams polling for updates.