-
Notifications
You must be signed in to change notification settings - Fork 276
Bugfix 2279 backport #2644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Bugfix 2279 backport #2644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous attempts 019ec2f and a6640d5 fixed most cases reported in an issue DOMjudge#1708, but there's still a case where a wrong error message is shown. This fixes it. (cherry picked from commit 07e3235)
This reverts commit a714386.
(cherry picked from commit ac40ef6)
(cherry picked from commit b26ebfb)
...roblem (cherry picked from commit 56104f6)
(cherry picked from commit eaf95fe)
...ntity (cherry picked from commit affacb4)
@cubercsl
cubercsl
force-pushed
the
bugfix-2279-backport
branch
from
August 3, 2024 10:29
b00a8ec to
b36292c
Compare
Nullsafe operator is supported since PHP8. Avoid using nullsafe operators in PHP7, as domjudge 8.2 branch needs to support PHP 7.4 Signed-off-by: cubercsl <2014cais01@gmail.com>
Hi @cubercsl,
I think we will delay this one for after the Astana WF, thanks for the work though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
a714386 does not fix #2279 indeed, and introduces the issue described in #2600. This PR will backport some fix to the 8.2 branch.