-
Notifications
You must be signed in to change notification settings - Fork 9
Comments
Use pandas[output_formatting] extra instead of direct jinja2 dependency#551
Open
ecomodeller wants to merge 1 commit intomain from
Open
Use pandas[output_formatting] extra instead of direct jinja2 dependency #551ecomodeller wants to merge 1 commit intomain from
ecomodeller wants to merge 1 commit intomain from
Conversation
Changed from directly specifying jinja2 to using pandas[output_formatting] extra, which includes jinja2 as a dependency. This is cleaner because: - Reduces direct dependencies to maintain - Makes explicit that jinja2 is needed for pandas styling - Lets pandas manage jinja2 version compatibility Tested: - All 589 tests pass - SkillTable styling functionality works correctly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification