-
Notifications
You must be signed in to change notification settings - Fork 631
Volume autogrow status updates #4270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Draft
+27
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The desiredPGDataVolume and desiredPGWALVolume status values should only be stored when a volume auto-grow event is imminent. This update adjusts the behavior so that this pattern is followed. Existing values will remain in place as needed if/when a Limit is removed. Issue: PGO-1428
In order to ensure the repo volume statuses are not cleared when an error is encountered, always return the PVC object from the applyRepoVolumeIntent function. Issue: PGO-1427
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Type of Changes:
What is the new behavior (if this is a feature change)?
Breaking change (fix or feature that would cause existing functionality to change)
Always return a PVC object when applying repo volume intent
In order to ensure the repo volume statuses are not cleared when
an error is encountered, always return the PVC object from the
applyRepoVolumeIntent function.
Only store pgData and pgWAL request values when autogrow is enabled
The desiredPGDataVolume and desiredPGWALVolume status values should
only be stored when a volume auto-grow event is imminent. This update
adjusts the behavior so that this pattern is followed.
Existing values will remain in place as needed if/when a Limit is
removed.
Other Information:
Issue: PGO-1427
Issue: PGO-1428