-
Notifications
You must be signed in to change notification settings - Fork 631
Add Disk Auto Grow for pgBackrest repo host volumes #4247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ca01ca3 to
267232b
Compare
This update adds the ability to automatically grow repo host PVCs. The AutoGrowVolumes feature gate must be enabled and the relevant volumes must include a Limit value. Once enabled, this feature tracks the current disk utilization and, when utilization reaches 75%, the disk request is updated to 150% of the observed value. At this point and beyond, the requested value will be tracked by CPK. The volume request can grow up to the configured limit value. Note: This change now treats limit values as authoritative regardless of the feature gate setting. However, the implementation also now allows limits to be updated after being set. Issue: PGO-1427
Issue: PGO-1427
b95d170 to
fd70aba
Compare
refactor for repo-host autogrow Issue: PGO-1427
fd70aba to
b395965
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we have an else case here and create an error? it looks like "if len == 1" we will just return nil
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 I wonder if the err == nil is necessary? Is there a scenario where we get an error and the Pod is returned?
I think the else block makes sense, I can add that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about it a bit more and I refactored the function to handle the errors better. Let me know if that works for you.
39e5f9b to
7b7739a
Compare
Checklist:
Type of Changes:
What is the new behavior (if this is a feature change)?
This update adds the ability to automatically grow repo host PVCs. The AutoGrowVolumes feature gate must be enabled and the relevant volumes must include a Limit value.
Once enabled, this feature tracks the current disk utilization and, when utilization reaches 75%, the disk request is updated to 150% of the observed value. At this point and beyond, the requested value will be tracked by CPK.
The volume request can grow up to the configured limit value. Note: This change now treats limit values as authoritative regardless of the feature gate setting. However, the implementation also now allows limits to be updated after being set.
Other Information:
Issue: PGO-1427