-
Notifications
You must be signed in to change notification settings - Fork 630
Add support for Azure AD Pod Identity in pgBackRest backups (#3275) #4213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @ljluestc ! Have you been able to successfully test this change in a live Azure cluster? I did not think this functionality was supported by pgBackRest, i.e., per this issue pgbackrest/pgbackrest#2023.
I do also see your PR is still in draft, so no worries if you're still digging into these details a bit. I just figured I'd reach out to see if there is anything I can do to help.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
docs/content/references/crd.md
to document the newpodIdentity
field inPostgresClusterSpec
, explaining its usage and configuration.ubi8-5.1.1-0
and Postgres 13, matching the issue’s environment.TestPodIdentityAzureBackup
ininternal/controller/pgbackrest/pgbackrest_controller_test.go
to verify pod identity environment variables and label configuration.Type of Changes:
What is the current behavior (link to any open issues here)?
pgo-azure-creds
) withAZURE_STORAGE_ACCESS_KEY
(issue Support Azure pod identity #3275 ).