forked from mattn/go-sqlite3
-
Notifications
You must be signed in to change notification settings - Fork 8
Keep up with upstream #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change could save users from having to dig into source code to see how connection options are parsed.
with comments what const are used for what
implementation of set_authorizer interface
Fix build
CryptEncoder SHA384 and SHA512 variants (with and without salt) were incorrectly documented as using SHA256.
Mention correct algorithm in function docs.
Upgrade to SQLite 3.25.0
Fix build
Actually check the value of RunTests
upgrade amalgamation code
Fix typo in README.md
Add Go 1.11 to Travis build matrix
Remove extra backtick and fix Markdown formatting
Update README: URL-encode connection options
Fix gometalinter issues
Clean up blob to byte slice conversion
Distinguish between NULL and zero-length blobs on query
Fix data race in AutoCommit()
Close db even if sqlite3_open_v2 return non-zero.
SQLITE_OPEN_CREATE should be specified for sqlite3_open_v2 if mode is...
... mode is not rw" This reverts commit 03b96a5.
Revert 671
upgrade amalgamation code
s/an/a/
Fix typo in README
As opposed to []byte arrays. This brings sqlite closer in line with other dbs like postgres, allowing downstream consumers to assume the scanned value is string across underlying dbs.
Unify travis runs
radutopala
commented
Feb 16, 2019
@auxten I see these issues
# github.com/mattn/go-sqlite3
sqlite3-binding.c:222430:42: error: too few arguments to function call, expected 3, have 2
sqlite3-binding.c:66273:1: note: 'sqlite3BtreeBeginTrans' declared here
sqlite3-binding.c:24:25: note: expanded from macro 'SQLITE_PRIVATE'
sqlite3-binding.c:222431:43: error: too few arguments to function call, expected 3, have 2
sqlite3-binding.c:66273:1: note: 'sqlite3BtreeBeginTrans' declared here
sqlite3-binding.c:24:25: note: expanded from macro 'SQLITE_PRIVATE'
sqlite3-binding.c:223249:46: error: too few arguments to function call, expected 3, have 2
sqlite3-binding.c:66273:1: note: 'sqlite3BtreeBeginTrans' declared here
sqlite3-binding.c:24:25: note: expanded from macro 'SQLITE_PRIVATE'
on fresh update from mattn.
Do you plan on updating the fork soon? Thanks.
Btw, develop works fantastic 😄
@auxten I see these issues
# github.com/mattn/go-sqlite3 sqlite3-binding.c:222430:42: error: too few arguments to function call, expected 3, have 2 sqlite3-binding.c:66273:1: note: 'sqlite3BtreeBeginTrans' declared here sqlite3-binding.c:24:25: note: expanded from macro 'SQLITE_PRIVATE' sqlite3-binding.c:222431:43: error: too few arguments to function call, expected 3, have 2 sqlite3-binding.c:66273:1: note: 'sqlite3BtreeBeginTrans' declared here sqlite3-binding.c:24:25: note: expanded from macro 'SQLITE_PRIVATE' sqlite3-binding.c:223249:46: error: too few arguments to function call, expected 3, have 2 sqlite3-binding.c:66273:1: note: 'sqlite3BtreeBeginTrans' declared here sqlite3-binding.c:24:25: note: expanded from macro 'SQLITE_PRIVATE'on fresh update from mattn.
Do you plan on updating the fork soon? Thanks.
Btw,
developworks fantastic 😄
hey, thanks for using it 😄
We are busy working on CovenantSQL now. For compatibility, we did not keep up with upstream. I merged @mattn 's upstream to branch keep-up, but have NOT done enough test. you can try it out. For any issue, glad to help.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.