Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Comments

Batch sumchecks in a Wire bundle #1248

Draft
amit0365 wants to merge 31 commits intoConsensys:master from
amit0365:wireBundle
Draft

Batch sumchecks in a Wire bundle #1248
amit0365 wants to merge 31 commits intoConsensys:master from
amit0365:wireBundle

Conversation

@amit0365
Copy link

@amit0365 amit0365 commented Aug 15, 2024
edited
Loading

Description

Added interface wireBundle to batch multiple sumchecks for different output wires in a single layer

Fixes # (issue)

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

  • TestMultipleDblAddSelectGKR

How has this been benchmarked?

  • Benchmark A, on Macbook pro M1, 32GB RAM
  • Benchmark B, on x86 Intel xxx, 16GB RAM

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

amit0365 and others added 30 commits June 11, 2024 21:53
...ted it in verify -m using emulated.assertequal in verify -m removed unused frombits in element as @arya pointed -m
... popoulated it in verify -m using emulated.assertequal in verify -m removed unused frombits in element as @arya pointed -m"
This reverts commit 6cbdc74.
...ager and populated it in verify" -m "Removed unused fromBits in Element"
Added verifier in ClaimsManager and populated it in verify
Using emulated.Assertequal in verify
Removed unused fromBits in Element
Copy link

CLAassistant commented Aug 15, 2024
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ TheDarkMatters
❌ amit0365


amit0365 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ivokub ivokub added the feat: gkr PRs related to GKR label Sep 11, 2025
@Tabaie Tabaie mentioned this pull request Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

feat: gkr PRs related to GKR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /