-
Notifications
You must be signed in to change notification settings - Fork 6
During SSA construction do a liveness check prior to inserting a phi #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
ChatGPT:
This is a known issue when following the SSA construction method described in Engineering a Compiler (by Cooper and Torczon). The method relies on dominance frontiers to place φ-functions, which can sometimes lead to the insertion of unnecessary φ-functions for variables that are not live at those points. This can cause issues in the renaming phase when a φ-function is encountered, but no reaching definition exists in the current rename stack.
Why This Happens:
Unnecessary φ-Functions: The standard algorithm places φ-functions at dominance frontiers without considering whether the variable is live at that point.
Renaming Phase Assumption: The renaming phase assumes that all φ-functions inserted are necessary and that there is always a valid definition in the rename stack. If a variable is not live at a φ-insertion point, then the rename stack may be empty, leading to errors.
Live-Range Violations: If a φ-function is placed at a block where the variable is not live, there might not be a previous definition, causing renaming to fail.