Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(DataGrid): tabbing doesnt properly bring cell into view, when cell expanded in edit-mode#4984

Open
Xiaoy312 wants to merge 1 commit intoCommunityToolkit:main from
Xiaoy312:datagrid/tab-scroll-into-view
Open

fix(DataGrid): tabbing doesnt properly bring cell into view, when cell expanded in edit-mode #4984
Xiaoy312 wants to merge 1 commit intoCommunityToolkit:main from
Xiaoy312:datagrid/tab-scroll-into-view

Conversation

@Xiaoy312
Copy link

@Xiaoy312 Xiaoy312 commented Apr 23, 2024

Fixes #4983

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

When moving to the next cell using Tab and this cell's size changing from entering edit-mode, the scroll-into-view is performed based on its previous size from the normal-mode.

What is the new behavior?

The scroll-into-view is performed again, if the cell size grows within a short time frame.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • Tested code with current supported SDKs
  • New component
    • Pull Request has been submitted to the documentation repository instructions. Link:
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
    • If control, added to Visual Studio Design project
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

related: unoplatform/uno#14311

@Xiaoy312 Xiaoy312 changed the title (削除) fix(DataGrid): tabbing doesnt properly bringing cell into view, when cell expanded in edit-mode (削除ここまで) (追記) fix(DataGrid): tabbing doesnt properly bring cell into view, when cell expanded in edit-mode (追記ここまで) Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DataGrid tabbing doesnt bring the next cell fully into view, when space allows

1 participant

AltStyle によって変換されたページ (->オリジナル) /