Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add FrameworkElementExtensions.CanDragElement#4498

Open
HavenDV wants to merge 2 commits intoCommunityToolkit:main from
HavenDV:add-candragelement-extension
Open

Add FrameworkElementExtensions.CanDragElement #4498
HavenDV wants to merge 2 commits intoCommunityToolkit:main from
HavenDV:add-candragelement-extension

Conversation

@HavenDV
Copy link
Contributor

@HavenDV HavenDV commented Feb 20, 2022
edited
Loading

Fixes #4490

PR Type

What kind of change does this PR introduce?

Feature

What is the current behavior?

What is the new behavior?

Added FrameworkElementExtensions.CanDragElement attached property that allows dragging elements with the mouse and equivalently WPF MouseDragElementBehavior

PR Checklist

Please check if your PR fulfills the following requirements:

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • Tested code with current supported SDKs
  • New component
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

Copy link

ghost commented Feb 20, 2022

Thanks HavenDV for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from azchohfi and michael-hawker February 20, 2022 05:05
@HavenDV HavenDV changed the title (削除) [IN PROCESS] Add FrameworkElementExtensions.CanDragElement (削除ここまで) (追記) [Work in progress] Add FrameworkElementExtensions.CanDragElement (追記ここまで) Feb 20, 2022
@HavenDV HavenDV changed the title (削除) [Work in progress] Add FrameworkElementExtensions.CanDragElement (削除ここまで) (追記) Add FrameworkElementExtensions.CanDragElement (追記ここまで) Feb 20, 2022
@michael-hawker michael-hawker added this to the 8.0 milestone Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michael-hawker michael-hawker Awaiting requested review from michael-hawker

@azchohfi azchohfi Awaiting requested review from azchohfi

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Projects

Status: No status

Milestone

8.0

Development

Successfully merging this pull request may close these issues.

[Feature] Add WPF MouseDragElementBehavior alternative

AltStyle によって変換されたページ (->オリジナル) /