Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[SampleApp] Fix GitHub icon not being centered#4494

Open
marcelwgn wants to merge 2 commits intoCommunityToolkit:main from
marcelwgn:dev/fix-github-icon
Open

[SampleApp] Fix GitHub icon not being centered #4494
marcelwgn wants to merge 2 commits intoCommunityToolkit:main from
marcelwgn:dev/fix-github-icon

Conversation

@marcelwgn
Copy link
Contributor

@marcelwgn marcelwgn commented Feb 17, 2022
edited by michael-hawker
Loading

Fixes #4489

Fixes the GitHub icon not being centered:

Screenshot of toolbar with GitHub button

PR Type

What kind of change does this PR introduce?

What is the current behavior?

The icon is not centered as shown in #4489

What is the new behavior?

Icon is centered 🎉

PR Checklist

Please check if your PR fulfills the following requirements:

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • Tested code with current supported SDKs
  • New component
    • Pull Request has been submitted to the documentation repository instructions. Link:
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
    • If control, added to Visual Studio Design project
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

Copy link

ghost commented Feb 17, 2022

Thanks chingucoding for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from azchohfi and michael-hawker February 17, 2022 22:00
@ghost ghost added bug 🐛 An unexpected issue that highlights incorrect behavior sample app 🖼 labels Feb 17, 2022
Copy link
Contributor Author

I dont want to rush this PR but is there a chance this can get merged? 😅

Copy link
Contributor Author

@dotnet-policy-service agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Arlodotexe Arlodotexe Arlodotexe approved these changes

@michael-hawker michael-hawker Awaiting requested review from michael-hawker

@azchohfi azchohfi Awaiting requested review from azchohfi

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

bug 🐛 An unexpected issue that highlights incorrect behavior sample app 🖼

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[SampleApp] GitHub icon not centered (NIT)

AltStyle によって変換されたページ (->オリジナル) /