Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Add Currency validation to TextBoxExtensions#4469

Open
NaftoliOst wants to merge 2 commits intoCommunityToolkit:main from
NaftoliOst:main
Open

Add Currency validation to TextBoxExtensions #4469
NaftoliOst wants to merge 2 commits intoCommunityToolkit:main from
NaftoliOst:main

Conversation

@NaftoliOst
Copy link

@NaftoliOst NaftoliOst commented Jan 25, 2022

Fixes #4188

Adds a currency validation option to the TextBoxExtensions

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

The Decimal validation does not allow currency signs, e.g. $ or €.

What is the new behavior?

With the Currency validation type, any valid decimal with or without currency signs will be allowed.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • New component
    • Pull Request has been submitted to the documentation repository instructions. Link:
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
    • If control, added to Visual Studio Design project
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

The code here could be refactored once The PR to add IsCurrency to StringExtensions gets merged.

Copy link

ghost commented Jan 25, 2022

Thanks NaftoliOst for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from azchohfi and michael-hawker January 25, 2022 13:11
Copy link

net-foundation-cla bot commented Jan 25, 2022 •
edited
Loading

CLA assistant check
All CLA requirements met.

Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ NaftoliOst sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@ghost ghost added the feature request 📬 A request for new changes to improve functionality label Jan 25, 2022
Copy link
Contributor

Hi @NaftoliOst , it appears you're trying to merge this code in from the main/master branch of your forked repo.

Please be aware of the rules & stipulations of submitting code into the Toolkit repo (these rules are in place due to issues we encounter when trying to merge in code from a user's main branch, into the toolkit's main branch):

image

Copy link
Author

Ah, thanks for pointing that out @XAML-Knight
Is it possible for me to change that on this PR or do I need to close it and open a new one?

Copy link
Contributor

Ah, thanks for pointing that out @XAML-Knight Is it possible for me to change that on this PR or do I need to close it and open a new one?

Go ahead and open a new PR from one of your dev branches, and then we'll also close this one.

@michael-hawker michael-hawker added this to the 8.0 milestone Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michael-hawker michael-hawker Awaiting requested review from michael-hawker

@azchohfi azchohfi Awaiting requested review from azchohfi

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

feature request 📬 A request for new changes to improve functionality

Projects

None yet

Milestone

8.0

Development

Successfully merging this pull request may close these issues.

[Feature] Add Currency format to TextBoxExtensions

AltStyle によって変換されたページ (->オリジナル) /