-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Conversation
Contributor
👋 @rubenvdlinde
Thank you for raising your pull request.
Please make sure you have followed our contributing guidelines. We will review it as soon as possible. In the meanwhile make sure your PR checks the following boxes
- Is based on an issue
- Has been locally tested
- Has been tested with the admin UI
- Has been discussed with the development team in an open channel
rjzondervan
rjzondervan
previously approved these changes
Jan 18, 2023
WilcoLouwerse
WilcoLouwerse
requested changes
Jan 18, 2023
$this->handleMetadataSelf($result, $metadataSelf);
$result = $this->shouldWeUnsetEmbedded($result, $this->data['headers']['accept'] ?? null, $isCollection ?? false);
// $result = $this->shouldWeUnsetEmbedded($result, $this->data['headers']['accept'] ?? null, $isCollection ?? false);
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dit willen we volgensmij alleen voor kiss doen en niet op master.
Dit zorgt dat we altijd embedded tonen namelijk.
Waar, al dus Barry, we voor roxit deze functie gebruiken en alleen voor accept header json+ld embedded tonen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the id or _id properties on plugin data to set the id on object entities