-
Notifications
You must be signed in to change notification settings - Fork 175
Enable logging in the Simulator #591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@scgbckbone
scgbckbone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like your simulator logging file part. That seem very useful to me as you cannot copy/pasta from termux itself. I would like that change to be split from other docker stuff & resolved my two review comments.
I'm not sure your dockerfile belongs to this repo - would be better if you create your own repo where other users can add other dockerfiles (for instance different os version/type, python version etc.). We can mention your repo in README.md of course.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logfile needs to take into consideration whether simulator is run with --segregate argument. If yes, you need to add log to the specific simulator directory /tmp/cc-simulators/<pid>/cc_simulator.log
check few lines up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to see this parametrized, so it only logs to file if user runs simulator with some specific flag (for instance --logf), as I worry about performance penalty when running multiple simulators
Uh oh!
There was an error while loading. Please reload this page.
EDITED: Removed docker.
(削除) Adds a newDockerfilefor building the simulator (削除ここまで)(削除) UpdatesREADME.mdwith instructions for building the simulator using Docker (削除ここまで)/tmp/cc_simulator.logto facilitate debugging of./simulator.pyfirmwarefolder to.gitignore.Tested on Linux Mint 22.2 (zara)