Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

refactor tutorial #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
niccokunzmann merged 2 commits into master from refactoring
Mar 7, 2018
Merged

refactor tutorial #115

niccokunzmann merged 2 commits into master from refactoring
Mar 7, 2018

Conversation

Copy link
Member

@niccokunzmann niccokunzmann commented Mar 6, 2018
edited
Loading

 - move js code from tutorial.html to js file
 - use - in front of jekyll commands to remove white space
 - remove test output of language tag
 - remove jquery because the selected language is selected in jekyll
Copy link
Collaborator

@niccokunzmann Everything looks great. Is there anything specific you needed me to do for this?

Copy link
Member Author

@DaricusDuncan No, nothing specific. Thanks for having a look. Through pull requests we can spread knowledge and appreciation :) If you like, you can merge.

@niccokunzmann niccokunzmann merged commit fc8df5b into master Mar 7, 2018
@niccokunzmann niccokunzmann deleted the refactoring branch March 7, 2018 08:26
Copy link
Member Author

I merged it to not forget it. Thanks for reviewing :)

Copy link
Collaborator

@niccokunzmann You are welcome. I forgot to respond back to you yesterday, but I did not have access to merge. The button to merge was not clickable. I should have told you sooner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaricusDuncan DaricusDuncan Awaiting requested review from DaricusDuncan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /