-
-
Notifications
You must be signed in to change notification settings - Fork 311
Comments
Add ability to set custom alternate animation suffix#882
Add ability to set custom alternate animation suffix #882r6915ee wants to merge 2 commits intoCodenameCrew:main from
Conversation
The alt. animation toggle event currently does not support setting the suffix directly, but that's outside of the scope of adding this feature at the moment.
Now that I think about it, I'll probably add support for prefixes as well, as it makes sense like with the window titles. I'll put it back as a draft pull request for now and then convert it once I've made the change. (I'm not renaming the branch for this, I don't want to remake the pull request.)
r6915ee
commented
Feb 4, 2026
Okay, there are some issues with events in particular (recycling appears to be definition-dependent in terms of parameter location) that prevent the easy implementation of prefixes. As a result, I'll ready the pull request for review again in its current state, but in my case I'll keep the animation prefix feature in mind; I have some ideas on how to implement that, alongside a potential backward-incompatible rewrite to the character animation system, but those are outside the scope of this pull request at the moment.
This pull request simply adds the ability to set the alt. animation suffix. As part of this:
DEFAULT_ALT_ANIM_SUFFIX, that sets the default suffix for alt. animations. By default, it is set to-altin order to retain compatibility.StrumLinewas introduced, that beingdefaultAnimSuffix, which is used to replace the suffix per-strumline. By default, it is set to theDEFAULT_ALT_ANIM_SUFFIXflag mentioned above.Alt Animation Togglewill automatically make use of the property above.This change is primarily intended to technically allow for much more alt. animations on a single character without going through the process of a complete character change, thus acting as a more performant variant of theoretically "switching" characters.
Do note that, although the
Alt Animation Toggleevent has been updated to take advantage of the new per-strumline property, it did not receive any changes to allow setting the suffix directly as that is outside of the scope of the pull request (at least, in my opinion).