-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Optimize calculateFreebuffStreak to single-pass iteration - #1260
Open
pavankumar-vh wants to merge 1 commit into
Open
Optimize calculateFreebuffStreak to single-pass iteration #1260pavankumar-vh wants to merge 1 commit into
pavankumar-vh wants to merge 1 commit into
Conversation
The function iterated through usageDates twice: 1. Once with filter() to build the usageDateSet 2. Once with reduce() to find lastUsageDate This is O(2n) when it could be O(n) by combining both operations in a single loop. Combined both operations into one loop, building the set and tracking the latest date simultaneously. This is more efficient and clearer in intent.
codebuff-team
commented
Sep 4, 2026
Contributor
Good, minimal change. Combining the filter+reduce into a single for loop is a correct, low-risk optimization — the semantics are preserved exactly (dates > todayDateKey are skipped for both the set and lastUsageDate, and lastUsageDate tracking logic matches the original reduce behavior). Scope is appropriately narrow, touching only common/src/util/freebuff-streak.ts.
A couple of minor notes for next time:
- The perf gain here is negligible in practice (
usageDatesis presumably a small, bounded list of recent days), so the value of this PR is more about clarity/idiom than actual performance. That's fine, but framing it as an optimization with O(2n)->O(n) claims is a bit oversold for what's really a readability tweak. - No new test was added to lock in the refactor, though the existing 14 tests passing is reasonable confirmation for a pure refactor like this.
Overall this is a clean, easy-to-review change that a maintainer could port by hand with minimal effort. Nice first contribution.
@codebuff-team
codebuff-team
added
bot:triaged
Classified by the community triage bot
pr:port-candidate
Worth porting into the private source tree
labels
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Optimize the
calculateFreebuffStreakfunction incommon/src/util/freebuff-streak.tsto use a single pass instead of two iterations.Bug Description
The function iterated through
usageDatestwice:filter()to build theusageDateSetreduce()to findlastUsageDateThis is O(2n) when it could be O(n) by combining both operations in a single loop.
Fix
Combined both operations into one loop, building the set and tracking the latest date simultaneously. This is more efficient and clearer in intent.
Testing
All existing tests pass (14/14).
Files Changed
common/src/util/freebuff-streak.ts- Single-pass iteration optimizationScope
This change only touches
common/src/util/freebuff-streak.ts(a single file in the approvedcommon/area).