generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 42
London | 25-SDC-Nov | Zohreh Kazemianpour | Sprint 5 | Prep Exercises#305
Open
zohrehKazemianpour wants to merge 9 commits intoCodeYourFuture:main from
Open
London | 25-SDC-Nov | Zohreh Kazemianpour | Sprint 5 | Prep Exercises #305zohrehKazemianpour wants to merge 9 commits intoCodeYourFuture:main from
zohrehKazemianpour wants to merge 9 commits intoCodeYourFuture:main from
Conversation
@zohrehKazemianpour
zohrehKazemianpour
added
the
Needs Review
Trainee to add when requesting review. PRs without this label will not be reviewed.
label
Dec 16, 2025
@LonMcGregor
LonMcGregor
added
the
Review in progress
This review is currently being reviewed. This label will be replaced by "Reviewed" soon.
label
Jan 14, 2026
@LonMcGregor
LonMcGregor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good work on these tasks, there are some areas where you could improve further
@LonMcGregor
LonMcGregor
added
Reviewed
Volunteer to add when completing a review with trainee action still to take.
and removed
Needs Review
Trainee to add when requesting review. PRs without this label will not be reviewed.
Review in progress
This review is currently being reviewed. This label will be replaced by "Reviewed" soon.
labels
Jan 14, 2026
Author
zohrehKazemianpour
commented
Jan 26, 2026
Very good work on these tasks, there are some areas where you could improve further
Thanks for the review and the positive feedback!
Apologies for the delay in getting back to you. We've had a really busy few weeks focusing on the backend and prepping for our Codility tests. I’m going through your suggestions now and will implement the improvements across the tasks.
@zohrehKazemianpour
zohrehKazemianpour
added
the
Needs Review
Trainee to add when requesting review. PRs without this label will not be reviewed.
label
Jan 26, 2026
LonMcGregor
commented
Jan 27, 2026
Great work, these tasks are complete now!
@LonMcGregor
LonMcGregor
added
Complete
Volunteer to add when work is complete and all review comments have been addressed.
and removed
Needs Review
Trainee to add when requesting review. PRs without this label will not be reviewed.
Reviewed
Volunteer to add when completing a review with trainee action still to take.
labels
Jan 27, 2026
Author
zohrehKazemianpour
commented
Jan 27, 2026
Great work, these tasks are complete now!
Thank you so much for the complete label.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
This PR contains the Sprint 5 preparation exercise.
As I was not previously familiar with Python, it took me some time to get comfortable with the new concepts and syntax. I added as many comments as possible for educational purposes, as I plan to use this code later as a reference.
Questions
I would really appreciate any feedback on my implementation and suggestions on how I can improve my code quality.