-
-
Notifications
You must be signed in to change notification settings - Fork 42
London | SDC-Nov-25 | Pezhman Azizi | Sprint 3 | Implement shell tools (cat, ls, wc) In JavaScript With NodeJS#302
Conversation
@LonMcGregor
LonMcGregor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start on this sprint's tasks, I have spotted a few areas where you could improve code further
Your way of handling arguments works ok, but can you think of any downsides to managing your arguments by checking each one in the input arguments? Compare this approach which how you handled arguments in the python task. Which is better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason you only focus on -1 here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea to move this to its own function!
Learners, PR Template
Self checklist
Changelist
This PR adds JavaScript (NodeJS) implementations of the three shell tools required for the sprint: cat, ls, and wc.
Each tool is implemented in its own commit for clarity and easier review.
What's Included
cat.js
catls.js
-1(one entry per line)-a(show hidden files)fs.readdirSync()and simple filteringwc.js
-l,-w,-ctotallinefsfor UTF-8 byte counting📝 Notes
cat,ls,wc)