-
-
Notifications
You must be signed in to change notification settings - Fork 42
London | 25-SDC-Nov | Aida Eslamimoghadam | Sprint 5 | Prep exercises#298
London | 25-SDC-Nov | Aida Eslamimoghadam | Sprint 5 | Prep exercises #298aydaeslami wants to merge 17 commits intoCodeYourFuture:main from
Conversation
Your PR couldn't be matched to an assignment in this module.
Please check its title is in the correct format, and that you only have one PR per assignment.
If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).
If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.
@LonMcGregor
LonMcGregor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good work on these tasks, there are some areas where you could improve further
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should not commit cache files like this, can you figure out how to remove them?
.DS_Store
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DS Store files don't need to be commited either
@LonMcGregor
LonMcGregor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work on these changes. This pull request is almost complete. The only thing I notice is the extra files like the DS_Store and the caches are still visible (if you click the files changed tab at the top of the page here).
I suggest checking that you have added them to the correct .gitignore files and then you may also need to take extra steps to remove them from the git.
aydaeslami
commented
Feb 11, 2026
Thank you @LonMcGregor for the suggestion. I’ve removed the DS_Store file from git and updated the .gitignore. The PR should be clean now.
@LonMcGregor
LonMcGregor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, this is complete now
Self checklist
Changelist
This PR includes debugging the Sprint 5 exercises related to types, classes, objects, inheritance, and composition.