Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

London | 25-SDC-July | Mikiyas Gebremichael | Sprint 1 | Debugging - Hashtag Slowing Down the Browser#119

Open
Mikiyas-STP wants to merge 2 commits intoCodeYourFuture:main from
Mikiyas-STP:debugging/hashtagslowingdownbrowsers
Open

London | 25-SDC-July | Mikiyas Gebremichael | Sprint 1 | Debugging - Hashtag Slowing Down the Browser #119
Mikiyas-STP wants to merge 2 commits intoCodeYourFuture:main from
Mikiyas-STP:debugging/hashtagslowingdownbrowsers

Conversation

@Mikiyas-STP
Copy link

@Mikiyas-STP Mikiyas-STP commented Feb 5, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

This PR is created to debug the Hashtag Slowing Down the Browser

Questions

no questions

@Mikiyas-STP Mikiyas-STP added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 5, 2026
Copy link
Member

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, but I have a few questions!

Comment on lines +19 to +20
state.currentHashtag = hashtag;
state.hashtagBlooms = [];
Copy link
Member

@illicitonion illicitonion Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any drawbacks to setting these here? Is it set anywhere else?

Jinja2==3.1.5
MarkupSafe==3.0.2
psycopg2==2.9.10
psycopg2-binary==2.9.10
Copy link
Member

@illicitonion illicitonion Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you have to make this change? What did it fix? It seems unrelated to the bug being fixed here?

@illicitonion illicitonion added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@illicitonion illicitonion illicitonion left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

Status: Backlog

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Comments

AltStyle によって変換されたページ (->オリジナル) /