Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

London | 26-ITP-Jan | Abdul Moiz | Sprint 3 | Alarm Clock#958

Open
A-Moiz wants to merge 1 commit intoCodeYourFuture:main from
A-Moiz:alarm-clock
Open

London | 26-ITP-Jan | Abdul Moiz | Sprint 3 | Alarm Clock #958
A-Moiz wants to merge 1 commit intoCodeYourFuture:main from
A-Moiz:alarm-clock

Conversation

@A-Moiz
Copy link

@A-Moiz A-Moiz commented Feb 13, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • Changed HTML Title
  • Created multiple functions in alarmclock.js for alarm clock functionality

Questions

N/A

@A-Moiz A-Moiz added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 13, 2026
<div class="centre">
<h1 id="timeRemaining">Time Remaining: 00:00</h1>
<label for="alarmSet">Set time to:</label>
<input id="alarmSet" type="number" />
Copy link

@codeschris codeschris Feb 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could look into preventing negative input (-1 or lower) and update the Javascript file to prevent your alarm clock from taking negative input

@codeschris codeschris added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@codeschris codeschris codeschris left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /