generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 224
London | 26-ITP-Jan | Mohsen Zamani | Sprint 3 | Todo List#956
Open
mohsenzamanist wants to merge 2 commits intoCodeYourFuture:main from
Open
London | 26-ITP-Jan | Mohsen Zamani | Sprint 3 | Todo List #956mohsenzamanist wants to merge 2 commits intoCodeYourFuture:main from
mohsenzamanist wants to merge 2 commits intoCodeYourFuture:main from
Conversation
@mohsenzamanist
mohsenzamanist
added
the
Needs Review
Trainee to add when requesting review. PRs without this label will not be reviewed.
label
Feb 10, 2026
This comment has been minimized.
This comment has been minimized.
@github-actions
github-actions
bot
removed
the
Needs Review
Trainee to add when requesting review. PRs without this label will not be reviewed.
label
Feb 10, 2026
This comment has been minimized.
This comment has been minimized.
@mohsenzamanist
mohsenzamanist
changed the title
(削除) London | 26-ITP-Jan | Sprint 3 | Mohsen Zamani | Todo List (削除ここまで)
(追記) London | 26-ITP-Jan | Mohsen Zamani | Sprint 3 | Todo List (追記ここまで)
Feb 10, 2026
@mohsenzamanist
mohsenzamanist
added
the
Needs Review
Trainee to add when requesting review. PRs without this label will not be reviewed.
label
Feb 10, 2026
MorganDavid
commented
Feb 14, 2026
Could you see if you can workout what's wrong with your title format
Sprint-3/todo-list/todos.test.mjs
Outdated
Comment on lines
132
to
134
const todosAfterDeletion = createMockTodos().filter(
(todo) => !todo.completed
);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's best to avoid logic in your tests and hard code a number instead. What if your test has a bug?
@mohsenzamanist
mohsenzamanist
added
Needs Review
Trainee to add when requesting review. PRs without this label will not be reviewed.
and removed
Needs Review
Trainee to add when requesting review. PRs without this label will not be reviewed.
labels
Feb 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Complete Sprint 3 Todo List
Questions