-
Notifications
You must be signed in to change notification settings - Fork 105
Suggestion Window Fixes #350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
thecoolwinter
merged 4 commits into
CodeEditApp:main
from
thecoolwinter:suggestion-fixes
Aug 27, 2025
Merged
Suggestion Window Fixes #350
thecoolwinter
merged 4 commits into
CodeEditApp:main
from
thecoolwinter:suggestion-fixes
Aug 27, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@thecoolwinter
thecoolwinter
requested review from
austincondiff,
0xWDG and
FastestMolasses
August 25, 2025 17:40
0xWDG
0xWDG
approved these changes
Aug 27, 2025
nkleemann
added a commit
to nkleemann/CodeEditSourceEditor
that referenced
this pull request
Aug 27, 2025
@thecoolwinter
thecoolwinter
merged commit Aug 27, 2025
424453d
into
CodeEditApp:main
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Description
Generally improves a few UX bugs with the suggestion window. Specifically the window would flash often even if the controller did not re-request new items, and would sometimes move the window when it shouldn't have. Also adjusts the window's x position to align the completion labels with the text.
Also includes a few changes fixing some build warnings.
Related Issues
Checklist
Screenshots
Screen.Recording.2025年08月25日.at.12.32.40.PM.mov