Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

macOS Tahoe Toolbar #2122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thecoolwinter wants to merge 13 commits into main
base: main
Choose a base branch
Loading
from feat/tahoe-toolbar
Open

macOS Tahoe Toolbar #2122

thecoolwinter wants to merge 13 commits into main from feat/tahoe-toolbar

Conversation

Copy link
Collaborator

@thecoolwinter thecoolwinter commented Aug 28, 2025
edited
Loading

Description

Updates the toolbar for macOS Tahoe. All changes in this PR should not affect existing functionality or design.

Related Issues

Checklist

  • Navigator extends to the top of the toolbar.
  • Task start/stop buttons in group.
  • Toolbar no longer compact (taller)
  • Extra padding on branch picker.
  • Activity viewer no longer has a background color.
  • Schema select hover is rounded.
  • Task select hover is rounded.
  • Activity viewer padding.
  • Task status padding too short.
  • Task status animation slightly wrong.
  • Notifications and activity viewer are combined in one glass item.
  • Notification item keeps space when hidden.
  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

All toolbar sta
Screenshot 2025年08月29日 at 4 33 01 PM
Screenshot 2025年08月29日 at 4 32 57 PM
Screenshot 2025年08月29日 at 4 32 44 PM
Screenshot 2025年08月29日 at 4 32 36 PM
tes:

Compression
Screen.Recording.2025年08月29日.at.4.33.20.PM.mov
Toolbar in action
Screen.Recording.2025年08月29日.at.4.30.35.PM.mov
Popovers
Screen.Recording.2025年08月29日.at.11.58.48.AM.mov
Task notification viewer
Screen.Recording.2025年08月29日.at.12.23.59.PM.mov

lin72h reacted with thumbs up emoji
@thecoolwinter thecoolwinter added enhancement New feature or request macOS Tahoe Issues for macOS Tahoe labels Aug 28, 2025
Copy link

Looking at the images, the bottom line of the toolbar is not aligned with the line in the sidebar and in the inspector. It's not a straight line across the toolbar and the sidebars. Is that something that Apple's frameworks are rendering or CodeEdit?

Copy link

It seems the toolbar has significantly longer height than it should have

Copy link
Collaborator Author

Looking at the images, the bottom line of the toolbar is not aligned with the line in the sidebar and in the inspector. It's not a straight line across the toolbar and the sidebars. Is that something that Apple's frameworks are rendering or CodeEdit?

It's a bit of both. The built-in toolbar no longer has a set size across each so we'll probably follow Xcode's lead and change it up. That's not actually a part of the toolbar in CE though, so it'll be a different PR.

Copy link
Collaborator Author

It seems the toolbar has significantly longer height than it should have

It's larger now but it also looks significantly larger because we have some hard-coded top padding in components that will need to be updated.

Copy link

It seems the toolbar has significantly longer height than it should have

It's larger now but it also looks significantly larger because we have some hard-coded top padding in components that will need to be updated.

May I ask which components need this top padding removed?

Copy link
Collaborator Author

It seems the toolbar has significantly longer height than it should have

It's larger now but it also looks significantly larger because we have some hard-coded top padding in components that will need to be updated.

May I ask which components need this top padding removed?

It should be the EditorLayoutView iirc and I think there's some in the navigator code. tbh I haven't looked into it yet.

Copy link
Collaborator Author

Ah shoot, you're totally right it is the toolbar making that space...

Screenshot 2025年08月29日 at 12 44 19 PM

Copy link
Collaborator Author

Good catch, figured it out. Can't use the .unified toolbar style it has to be .automatic.

Copy link
Collaborator Author

Well that unified to default change led to a whole slew of bugs but I think this is ready to go!

@thecoolwinter thecoolwinter marked this pull request as ready for review August 29, 2025 21:37
Copy link

Yeah size seems perfect now. But the toolbar background is getting this transparent effect from the tahoe default toolbar styling.
I'd assume .scrollEdgeEffectStyle(.hard) could help but couldn't get that to work

2025年08月30日_07-12-29

Copy link
Collaborator Author

Yeah size seems perfect now. But the toolbar background is getting this transparent effect from the tahoe default toolbar styling.

I'd assume .scrollEdgeEffectStyle(.hard) could help but couldn't get that to work

2025年08月30日_07-12-29

Shoot! I forgot to double check it on dark mode. I'll take a look.

Copy link
Collaborator Author

Okay two things with the transparency. It's inconsistent when it's that opaque on light mode, almost like it only remembers to do so after it's been changed from dark mode.

I think it's the right move to have it pretty transparent. But the gutter view is not having the glass effect applied to it for some reason... I'm going to see if I can fix that as a CESE issue and leave the transparency in the toolbar.

When I move on to tabs next I may explore making them sit on a glass element.

Copy link
Collaborator Author

Okay yeah this is partly a liquid glass bug. It's not applying the glass styling to floating scrollview views. I'll submit a feedback and then we'll need to consider how to move forward. Probably making the toolbar less opaque.

Copy link

Usually it applies the blurring to SwiftUI scrollviews or lists automatically but Im guessing the underlying codeeditorview is far from swiftui.
Also, I’d say its fine for the toolbar to be opaque, similar to Xcode 26 since there are elements like tabviww and jumpbar below it

Copy link
Collaborator Author

Yeah it appears that the liquid glass effect just doesn't apply to floating scrollview views. I've submitted a feedback for it, we may just have to clip the gutter to the visible area for now. And yeah the editor view isn't SwiftUI it's mostly AppKit.

Copy link
Collaborator

What if we added a layer underneath for now instead of clipping it?

Copy link
Collaborator Author

thecoolwinter commented Sep 2, 2025
edited
Loading

What if we added a layer underneath for now instead of clipping it?

Good thought, I can try it

Copy link
Collaborator Author

It looks great on the tab bar but the gutter still overflows everything. I'm really not sure how to move forwards with it. Same is true of the minimap divider view, glass just completely ignores it no matter what.

Copy link
Collaborator Author

Screenshot 2025年09月02日 at 12 45 32 PM

There's a second bug going on here too where again the toolbar sometimes just forgets to apply the glass effect to anything like in this screen cap. This is frustrating to work with

Copy link
Collaborator Author

Screenshot 2025年09月02日 at 12 46 37 PM

After a little messing around it remembers, but the gutter and minimap dividers are still unaffected.

Copy link
Collaborator Author

Alright finally got an under-toolbar visual effect item to work! And it seems to have fixed the bug or at least made it unnoticeable. It is noticeable that it isn't glass, but maybe we can figure out a fix from CESE's side of things with the gutter view and minimap view.

Copy link
Collaborator Author

Copy link
Collaborator Author

I did originally have glass instead of a plain visualeffectview, but glass has a deactivated state that makes it obvious we're injecting something behind the toolbar. Maybe we can subclass NSGlassEffectView and change that but this works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austincondiff austincondiff Awaiting requested review from austincondiff

@0xWDG 0xWDG Awaiting requested review from 0xWDG

@matthijseikelenboom matthijseikelenboom Awaiting requested review from matthijseikelenboom

@FastestMolasses FastestMolasses Awaiting requested review from FastestMolasses

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request macOS Tahoe Issues for macOS Tahoe
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /