Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(humanize): tolerate moving targets after scroll#355

Open
Kumario1 wants to merge 2 commits into
CloakHQ:main from
Kumario1:fix/human-stable-check-budget
Open

fix(humanize): tolerate moving targets after scroll #355
Kumario1 wants to merge 2 commits into
CloakHQ:main from
Kumario1:fix/human-stable-check-budget

Conversation

@Kumario1

@Kumario1 Kumario1 commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

Fixes #329.

Summary

  • Treat the extra post-scroll stable-position wait as best-effort for click, dblclick, and hover when the element remains in motion.
  • Keep pre-scroll actionability and final pointer-event checks strict, then use the latest bounding box for the target.
  • Add JS and Python regressions for moving targets after scroll.

Verification

  • cd js && npm test -- humanize.test.ts
  • cd js && npm run typecheck
  • python -m pytest tests/test_humanize_unit.py::TestPerCallTimeoutForwarding tests/test_humanize_unit.py::TestPostScrollStability tests/test_humanize_unit.py::TestPointerEventsFailOpen::test_handle_failopen_returns_on_evaluate_error tests/test_humanize_unit.py::TestPointerEventsFailOpen::test_locator_failopen_returns_on_evaluate_error tests/test_humanize_unit.py::TestPointerEventsFailOpen::test_handle_still_raises_when_covered -q

Note: full tests/test_humanize_unit.py is not clean in this local environment because pytest-asyncio is unavailable and several existing tests launch real browsers or hit external pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

idx=2, err=Element 'div.parent-comment >> nth=1 >> div.reply-container >> div.show-more' failed stable check: element position is still changing

1 participant

AltStyle によって変換されたページ (->オリジナル) /