-
Notifications
You must be signed in to change notification settings - Fork 622
Added pr triage workflow#2878
Merged
Merged
Conversation
Repository collaborators can run the JMH benchmark suite against this PR by commenting:
/benchmark
Optional regression threshold override (Δ% on Time or Alloc/op; defaults to 10%):
/benchmark threshold=15
Only one benchmark run per PR is active at a time — issuing a new /benchmark comment cancels the previous run. After the run finishes a separate comment will be posted comparing it against the latest scheduled run on main; the PR check fails if any benchmark regresses by more than the threshold.
chernser
commented
Jun 15, 2026
Contributor
Author
/triage
Client V2 CoverageCoverage Report
Class Coverage
|
JDBC V2 CoverageCoverage Report
Class Coverage
|
JDBC V1 CoverageCoverage Report
Class Coverage
|
Client V1 CoverageCoverage Report
Class Coverage
|
chernser
commented
Jun 16, 2026
Contributor
Author
/triage
Triage
Category: infra • Risk: medium
Summary
This PR adds a single new GitHub Actions workflow file (.github/workflows/claude-pr-triage.yml) that wires up automated Claude-based PR triage for this repository. It triggers on pull_request (ready_for_review, synchronize) and on issue_comment when a trusted collaborator (OWNER/MEMBER/COLLABORATOR) posts /triage. The job delegates entirely to a pinned reusable workflow in ClickHouse/integrations-shared-workflows at SHA 3d91ad26a6d8e9164eb120fb0433ec2defd5c68a, passing the repo-specific triage rubric as a parameter and the ANTHROPIC_API_KEY org secret. No library source, tests, or build configuration is touched.
What this impacts
.github/— adds a new workflow; no existing workflows modified- CI/automation surface — new automated commenting/labeling behavior on every non-draft PR open or sync event
- Secret exposure:
ANTHROPIC_API_KEYorg secret is forwarded to the external reusable workflow
Concerns
- Medium risk rule fired: "GitHub workflow changes — any other changes in the
.githubdirectory." This is the sole trigger for the medium rating. - The reusable workflow is pinned to a full commit SHA (good for supply chain security), but reviewers should verify that SHA corresponds to a trusted, reviewed version of
ClickHouse/integrations-shared-workflows. - The
pull-requests: writepermission combined with anissue_commenttrigger is a recognized attack surface (fork PRs can trigger comment events). The guardgithub.event.comment.author_associationbeing one of OWNER/MEMBER/COLLABORATOR mitigates this, but reviewers should confirm the reusable workflow itself does not expand permissions further.
Required reviewer action
- At least one human reviewer should verify the pinned SHA in
integrations-shared-workflowsand confirm the secret forwarding scope is acceptable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit bf30b53. Configure here.
chernser
commented
Jun 16, 2026
Contributor
Author
/triage
1 similar comment
chernser
commented
Jun 16, 2026
Contributor
Author
/triage
Quality Gate Passed Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
mshustov
mshustov
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Summary
/triageto call on some PRNote
Low Risk
CI-only addition with no library or runtime behavior changes; it consumes an existing org secret and follows the same reusable-workflow pattern as other
.githubworkflows.Overview
Adds a PR Triage GitHub Actions workflow that runs automated Claude-based triage for non-draft PRs on
ClickHouse/*repos when a PR becomes ready or is updated, and on demand when a trusted collaborator posts/triageon the PR thread.The workflow delegates to a pinned reusable workflow in
ClickHouse/integrations-shared-workflowsand passes repo-specifictriage_instructions: PR category labels (bugfix,feature,infra, etc.), ClickHouse .NET driver high/medium/low risk heuristics (API, types, protocol, security,.githubchanges, and more), and required reviewer actions tied to risk level. It usespull-requests: write, per-PR concurrency with cancel-in-progress, andANTHROPIC_API_KEY.Reviewed by Cursor Bugbot for commit bf30b53. Bugbot is set up for automated code reviews on this repo. Configure here.