SSZ Multiproof#57

Open

ec2 wants to merge 37 commits intodevelop from

ec2/ssz-multiproof

Open

SSZ Multiproof #57
ec2 wants to merge 37 commits intodevelop from
ec2/ssz-multiproof

Conversation

@ec2

Copy link

Contributor

@ec2 ec2 commented Jan 23, 2024 •

edited

Loading

TODO:
[x] Clean up some duplicate code
[x] Consider removing some of the preprocessor tests which only test individual circuits
[x] Fix spec tests

This PR reduces the amount of advice cells being used. We merklize a whole beacon header in circuit when what we really want is just a merkle proof for a couple specific fields.
Before:

read params from ./params/kzg_bn254_21.srs
Gate Chip | Phase 0: 11535114 advice cells
Total 2059 fixed cells
Total range check advice cells to lookup per phase: [1222736, 0, 0]
Gate Chip | Phase 0: 1599532 advice cells
Total 1795 fixed cells
Total range check advice cells to lookup per phase: [4096, 0, 0]
test tests::test_both_circuit_sepolia has been running for over 60 seconds
test tests::test_both_circuit_sepolia ... ok

After:

read params from ./params/kzg_bn254_21.srs
Gate Chip | Phase 0: 11182651 advice cells
Total 2035 fixed cells
Total range check advice cells to lookup per phase: [1188896, 0, 0]
Gate Chip | Phase 0: 1598616 advice cells
Total 1767 fixed cells
Total range check advice cells to lookup per phase: [4096, 0, 0]

ec2 added 19 commits

January 18, 2024 16:41

@ec2


 multiproof helpers

700583e

@ec2


 leaves for block header

5ca9cdd

@ec2


 in circuit multiproofs and step circuit integration

282dd5e

@ec2


 some comments

f195e04

@ec2


 gen test data using rust

67a9446

@ec2


 add new test data

9ff59e1

@ec2


 clippy

b91c039

@ec2


 more lints

1a00a19

@ec2


 remove typescript

7a136e6

@ec2


 Feature gate test gen to pull in less deps

35ec5c7

@ec2


 Merge branch 'ec2/unit-test-gen' into ec2/ssz-multiproof

a44fa8d

@ec2


 Merge branch 'main' into ec2/ssz-multiproof

8784d0d

@ec2


 fix unit tests for step circuit

6582bf9

@ec2


 fix unit tests for committee update circuits

ad80976

@ec2


 Fix spec tests

62c96be

@ec2


 some cleanup

27bdb04

@ec2


 clean up

4ef20b3

@ec2


 lint

dcc5f2c

@ec2


 remove preprocessor mock circuit tests in favor of testing both at th...

17d03ff

...e same time

@ec2 ec2 marked this pull request as ready for review

January 24, 2024 06:48

ec2 added 2 commits

January 24, 2024 07:22

@ec2


 fix default trait impl

@ec2


 Fix cargo.toml for feature flags

b227de1

nulltea

nulltea requested changes

Jan 25, 2024

View reviewed changes

lightclient-circuits/src/committee_update_circuit.rs Outdated Show resolved Hide resolved

lightclient-circuits/src/committee_update_circuit.rs Outdated

Comment on lines 91 to 94

.as_ref()

.iter()

.map(|v| builder.main().load_witness(F::from(*v as u64)))

.collect_vec();

Copy link

Member

@nulltea nulltea Jan 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have this in 5 or more places now (incl step circuit), might be worth putting this in a util method for this?

lightclient-circuits/src/ssz_merkle.rs Outdated Show resolved Hide resolved

lightclient-circuits/src/committee_update_circuit.rs Outdated Show resolved Hide resolved

preprocessor/src/rotation.rs Outdated Show resolved Hide resolved

preprocessor/src/step.rs Outdated Show resolved Hide resolved

test-utils/src/lib.rs Outdated Show resolved Hide resolved

ec2 added 2 commits

February 2, 2024 07:35

@ec2


 fix pr comments

e36da2e

@ec2


 change config in test

476a9b7

@ec2

Copy link

Contributor Author

ec2 commented Feb 2, 2024

I've removed the patch to halo2curves in the PR as well :D

@ec2


 fix the rest of pr review

f67efe8

@ec2 ec2 requested a review from nulltea

February 2, 2024 07:50

@ec2


 Merge branch 'main' into ec2/ssz-multiproof

335a38c

@nulltea nulltea changed the base branch from main to develop

March 5, 2024 13:33

nulltea

nulltea approved these changes

Mar 5, 2024

View reviewed changes

Copy link

Member

@nulltea nulltea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My point re. code repetition still stands. Otherwise LGMT

ec2 added 12 commits

March 20, 2024 14:56

@ec2


 Merge branch 'develop' into ec2/ssz-multiproof

44104c0

@ec2


 finish merge conflicts

e19071e

@ec2


 uipdate submodule

b4eb920

@ec2


 Merge branch 'develop' into ec2/ssz-multiproof

2a655ac

@ec2


 Merge branch 'develop' into ec2/ssz-multiproof

faae48e

@ec2


 compiles

b9a5fd6

@ec2


 fix test to compile

@ec2

fmt

e21399d

@ec2


 dont pin

26e925d

@ec2


 revert some tests

8d40442

@ec2


 update test params

9e95e4e

@ec2


 need to finish fixing unit_test_gen

2515ad9

Labels

None yet

2 participants

@ec2 @nulltea

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SSZ Multiproof#57

SSZ Multiproof #57
ec2 wants to merge 37 commits intodevelop from
ec2/ssz-multiproof

Conversation

@ec2 ec2 commented Jan 23, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

@nulltea nulltea Jan 25, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ec2 commented Feb 2, 2024

Uh oh!

@nulltea nulltea left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

@ec2 ec2 commented Jan 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

@nulltea nulltea Jan 25, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ec2 commented Feb 2, 2024

Uh oh!

@nulltea nulltea left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

@ec2 ec2 commented Jan 23, 2024 •

edited

Loading