-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
corrected the code at and changed to pt
#555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
correcte a typing blip in code for pytensor.tensor import
Actually it should be import pytensor.tensor as pt everywhere. I think in another file it was also using tt maybe.
Actually it should be
import pytensor.tensor as pteverywhere. I think in another file it was also usingttmaybe.
You are right actually, I just gave this recommendation in order to make it compatible with the code after it,
so if we change it to pt we have to change the T.stack in the following code too.
so if we change it to pt we have to change the T.stack in the following code too.
Yes, you're right. Can you make these changes?
np
changed the import of `pytensor.tensor` to pt and corrected the following code
at and changed to pt (追記ここまで)
Same in chapter 2: https://github.com/CamDavidsonPilon/Probabilistic-Programming-and-Bayesian-Methods-for-Hackers/pull/554/files#diff-9fc4a0e7834209ea34b4d28c88fadf5af42096ab64f5b4b0e4832b1aef201c0eR432
and 5: https://github.com/CamDavidsonPilon/Probabilistic-Programming-and-Bayesian-Methods-for-Hackers/pull/554/files#diff-c3fc32a9c505ecf8a7b24bead1eb807d7b267b5cf3675a302a916457892d9b8fR1090, 6: https://github.com/CamDavidsonPilon/Probabilistic-Programming-and-Bayesian-Methods-for-Hackers/pull/554/files#diff-199fdfea5b6b81e04e46186b1c01db27f75d876ddaad83a7e2c6c92f012394e2R1171
Great, did you rerun the NBs to make sure it's all working?
Great, did you rerun the NBs to make sure it's all working?
I wasn't at my computer to test it, just replaced by search
but I can check them later to see if everything is working ok.
I will comment it here if everything run OK.
Great, did you rerun the NBs to make sure it's all working?
There was no error related to pytensor.
there were some errors and warnings with some other parts which needs to be fixed later.
Sounds like it's good to merge?
@twiecki np, I'll do it.
correcte a typing blip in code for pytensor.tensor import