-
Notifications
You must be signed in to change notification settings - Fork 44
Open
Conversation
bineagu
commented
Apr 23, 2020
Author
Sorry if I did something wrong, this is my first attempt at a pull request :)
scott-wyatt
commented
Apr 23, 2020
Member
Thanks for the PR! 🎈🎈🎈I’ll take a look at soon as I can.
wbhob
commented
Apr 25, 2020
Contributor
This looks good, except you're also going to want to upgrade @angular/* in devDependencies (so that it compiles with latest angular) and in peerDependencies (so that consumers don't get type collisions with Angular 8-). Thanks for the PR!
egd-flaine
commented
Sep 10, 2020
Hello,
What's the status? Waiting for this merge : )
Thx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes:
Added the generic type in module declaration to support Angular 9.
Checklist:
npm run buildruns without errorng servespawns app, Intercom messenger is visible and interactive, and there are no errors in the consoleCloses issue: #101