-
Notifications
You must be signed in to change notification settings - Fork 130
Conversation
@opticod
opticod
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@codingblazer , your implementation for template repo is fine and merged it, but in this code there are some problems in your implementation.
Like, go to Simulator of Info Template and then click any one of the items in list, and now click back....user is in deadlock state, neither menu back nor navigation back is working here....Please fix this.
codingblazer
commented
May 9, 2017
@opticod Changes made !! Please review.
A side note - In Quiz and some templates having navigation bar, if let you open a simulator => Ques 1 appears, now if you open same from navigation bar => Press back => Nothing happens (it looks that bug is still not solved but it is !! (back press killed the duplicate instance of Ques 1)
opticod
commented
Sep 1, 2017
Will soon start reviewing and merging the PRs. Thanks.
Uh oh!
There was an error while loading. Please reload this page.
Fix #368
@opticod Please Review. PR for templates sent too.
I have also handled another case - Earlier on pressing back when navigation drawer was opened caused drawer and app both to close. Now only drawer closes.