-
Notifications
You must be signed in to change notification settings - Fork 19
Open
Conversation
aoles
aoles
requested changes
Apr 13, 2023
@aoles
aoles
left a comment
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot Mike @grimbough for providing the fix, and let me apologize for not getting back to you earlier 😇
Please consider resolving the conflicts in DESCRIPTION and NEWS files, and my inline comment. Once these are addressed I'm happy to merge 🚀
Merge branch 'devel' of git.bioconductor.org:packages/BiocStyle into glimma-plots # Conflicts: # DESCRIPTION # NEWS
grimbough
commented
Apr 26, 2023
Collaborator
Author
Hi @aoles
Sorry, I forgot about this before the release. I think I've made the appropriate changes for it do go into the current devel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #97
The issue is that the
process_tables()function adds the tag<div class='horizontal-scroll'>before any instances of<table>. This inadvertantly breaks the Javascript that Glimma inserts into the page, by including some unexpected quotes. Even if we change the quote type, adding this extra div is almost certainly not correct.This patch means the additional div is only inserted around
<table>tags that are part of the HTML body and not in the head.