-
Notifications
You must be signed in to change notification settings - Fork 263
update Patchwork from v0.5.2 to v0.5.5#538
Open
fethalen wants to merge 1 commit intoBioContainers:master from
Open
update Patchwork from v0.5.2 to v0.5.5 #538fethalen wants to merge 1 commit intoBioContainers:master from
fethalen wants to merge 1 commit intoBioContainers:master from
Conversation
Collaborator
biocontainers-bot
commented
Oct 24, 2023
please specify in about.license_file the location of the license file in the container, or a url to license for this release of the software.
Collaborator
biocontainers-bot
commented
Oct 24, 2023
Found a biotools entry matching the software name (https://bio.tools/Patchwork), if this is the same software, please add the extra.identifiers.biotools label to your Dockerfile
Collaborator
biocontainers-bot
commented
Oct 24, 2023
No test-cmds.txt (test file) present, skipping tests
Contributor
mboudet
commented
Oct 27, 2023
Hi. You can skip the biotools part, since it's a different container, but it would be great to add the license (same as before, GPL-3.0 I think?)
Another issue is that you are building from the last commit on git, meaning the container build is not reproductible. This PR should probably wait for a new 'release', so that we can fix on a tag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've submitted an update to the Dockerfile for Patchwork. Patchwork was updated to be compatible with newer versions of Julia and to ease up the compilation step. The Dockerfile was also tweaked to make it compatible with Apptainer/Singularity for users running HPC systems.
Two others versions of Patchwork have previously been submitted to Biocontainers.