-
Notifications
You must be signed in to change notification settings - Fork 263
Conversation
biocontainers-bot
commented
May 29, 2020
Found an existing bioconda package for this software (https://bioconda.github.io/recipes/samtools/README.html), is this the same, then you should update the recipe in bioconda to avoid duplicates.
biocontainers-bot
commented
May 29, 2020
No samtools/1.7.0/test-cmds.txt (test file) present, skipping tests
samtools/1.10/Dockerfile
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is bio.tools not samtools (https://bio.tools/samtools) ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link shows the tool is samtools, but it's not the home page of samtools. I am not sure what do you need here. I saw you used both LABEL extra.identifiers.biotools="SAM" and LABEL extra.binary = "SAMTOOLS" before.
osallou
commented
Jun 25, 2020
Biotools id is samtools, not sam , incorrectly used in older releases
biocontainers-bot
commented
Jun 25, 2020
Found an existing bioconda package for this software (https://bioconda.github.io/recipes/samtools/README.html), is this the same, then you should update the recipe in bioconda to avoid duplicates.
biocontainers-bot
commented
Jun 25, 2020
No samtools/1.7.0/test-cmds.txt (test file) present, skipping tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an eror here, version is 1.10.0
add samtools-1.10