-
-
Notifications
You must be signed in to change notification settings - Fork 23
Open
Conversation
@piedoom
piedoom
force-pushed
the
echo
branch
from
October 15, 2025 03:11
56e50df to
c14f76f
Compare
@piedoom
piedoom
force-pushed
the
echo
branch
2 times, most recently
from
October 29, 2025 04:15
8acf945 to
67f0dcc
Compare
piedoom
commented
Dec 14, 2025
Contributor
Author
OK, I did some additional testing, and it seems that the issue I was running into where all Notifys are immediately triggered is specific to the UI visual nodes graph example (and it happens with all nodes, and happened before this addition). Can dig in more but technically I think this is an existing "bug". The code itself should be fine
piedoom
piedoom
commented
Dec 14, 2025
/// Read the least recent sample pushed to this delay line (the sample that
/// will be replaced with the next [`Self::write_and_advance`]).
pub fn read_last(&self) -> f64 {
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all of this can use some bikeshedding, idk if these are correct terms
@piedoom
piedoom
force-pushed
the
echo
branch
from
January 15, 2026 03:41
c2caaa8 to
86071a2
Compare
@piedoom
piedoom
force-pushed
the
echo
branch
2 times, most recently
from
January 25, 2026 07:22
a3c50a2 to
6126465
Compare
piedoom
commented
Jan 25, 2026
Contributor
Author
Added a stereo and mono helper.
I also added some improved documentation that is hopefully more approachable for general developers instead of assuming audio programming knowledge.
added back stopping. pause still strange, time changing still can click smoothed filter values
...ixed wrapping issue causing occasional panics. Separated delay line into dsp.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Drafting to track #16 - some things to fix, but I think this is close. Still need to fix issues with pause behavior and time change clicking,
(削除) as well as smoothing filter values (done) (削除ここまで). There also may be some performance improvements to be made, especially with how I am handling interpolating between times.I modeled this after what I presume is happening with Bitwig's delay effect, which allows for both single echos and feedback delays.
Issue criteria:
(削除) tap_gain (削除ここまで)- I found this was redundant with themixandfeedbackfeedback_lpf. I think feedback is more generally understood than tap (and should be more accurate in this case as well).feedback_hpffor above reason(削除) enabled (削除ここまで)- Not needed withmixsettingAdditional features
Tradeoffs