Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

upgrade this module to fit 3.0#3

Open
Hardwell369 wants to merge 4 commits intoBigQuant:main from
Hardwell369:main
Open

upgrade this module to fit 3.0 #3
Hardwell369 wants to merge 4 commits intoBigQuant:main from
Hardwell369:main

Conversation

@Hardwell369
Copy link
Contributor

@Hardwell369 Hardwell369 commented Dec 30, 2024

This pull request includes changes to the src/sql_join_2/__init__.py file to improve the handling of SQL inputs and remove unused constants. The most important changes include adding validation for SQL inputs, modifying how SQL strings are read and parsed, and updating the output format.

Improvements to SQL input handling:

  • Added validation to ensure sql1 and sql2 are not empty before proceeding with the function execution.
  • Modified the way SQL strings are read and checked if they are dictionaries to extract the SQL string properly.

Codebase simplification:

  • Removed the LEARNING_ALGORITHMS and FAI_CLUSTERS constants, which were no longer being used in the codebase.

Output format update:

  • Changed the output format from writing text to writing JSON, encapsulating the SQL string in a dictionary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

Comments

AltStyle によって変換されたページ (->オリジナル) /