Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Fix UTF-8 Encoding Errors on TeamTalkClassic#2946

Open
hwangsihu wants to merge 1 commit intomaster from
utf-8
Open

Fix UTF-8 Encoding Errors on TeamTalkClassic #2946
hwangsihu wants to merge 1 commit intomaster from
utf-8

Conversation

@hwangsihu
Copy link
Contributor

@hwangsihu hwangsihu commented Oct 22, 2025

No description provided.

Copy link
Contributor

@bear101 bear101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is used by CTeamTalkDlg::OnCopyData

Copy link
Contributor

@hwangsihu the tt5srv.log file doesn't support utf 8 as well. if system locall is set to english, and in the teamtalk server, people send persion or arabik messages to each other for example, it replaces by question marks. Please fix this as wel. I've reported this before, but anyone didn't pay any attention.

@hwangsihu hwangsihu marked this pull request as draft October 26, 2025 07:39
@hwangsihu hwangsihu force-pushed the utf-8 branch 2 times, most recently from f00f048 to 3aced28 Compare October 26, 2025 10:15
@hwangsihu hwangsihu marked this pull request as ready for review October 26, 2025 11:29
Copy link
Contributor

bear101 commented Oct 27, 2025

@hwangsihu In Library/TeamTalkLib/teamtalk/Log.h try adding UnicodeToUtf8(TXT).c_str() on Windows.

#include "myace/MyACE.h"
#if defined(UNICODE)
#define TT_LOG(TXT) ACE_DEBUG((LM_INFO, ACE_TEXT("%D %s\n"), UnicodeToUtf8(TXT).c_str()))
#else
#define TT_LOG(TXT) ACE_DEBUG((LM_INFO, ACE_TEXT("%D %s\n"), TXT))
#endif

@hwangsihu hwangsihu changed the title (削除) Fix UTF-8 Encoding Errors on TeamTalkClassic (削除ここまで) (追記) Fix UTF-8 Encoding Errors (追記ここまで) Oct 27, 2025
Copy link
Contributor

@hwangsihu i'm sorry, did you see my comment? can the utf issue be fixed in windows server log file as well, So we don't have to change system local in auder to support persian and arabik langs when people send messages like this?

@hwangsihu hwangsihu force-pushed the utf-8 branch 3 times, most recently from a293db0 to 5d211ba Compare October 29, 2025 13:30
@hwangsihu hwangsihu changed the title (削除) Fix UTF-8 Encoding Errors (削除ここまで) (追記) Fix UTF-8 Encoding Errors on TeamTalkClassic (追記ここまで) Oct 29, 2025
Copy link
Contributor Author

Hmm... it doesn't work. Instead, I've encountered an absurd situation where English characters are broken.
For now, I think it would be better to create a separate PR to address this issue later.

@hwangsihu hwangsihu force-pushed the utf-8 branch 2 times, most recently from 220798e to f085c05 Compare December 3, 2025 02:09
@hwangsihu hwangsihu deleted the utf-8 branch December 5, 2025 08:21
@hwangsihu hwangsihu restored the utf-8 branch December 5, 2025 09:39
@hwangsihu hwangsihu requested review from Copilot and removed request for bear101 December 6, 2025 04:27
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor Author

@bear101 Sorry to bother you, but when can you approve my review? I converted the same symbols to UTF-8, so it should work fine.

szArg = info.m_args.GetNext(pos);
_tcsncat(msg.szPath, szArg.GetBuffer(), MAX_PATH);
_tcsncat(msg.szPath, _T("�"), MAX_PATH);
_tcsncat(msg.szPath, _T("¤"), MAX_PATH);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the same character as here?

Copy link
Contributor Author

Yes, just the encoding is different.

Copy link
Contributor

bear101 commented Jan 11, 2026

Yes, just the encoding is different.

So you have tested that the tokenize still works when you drag a .tt file onto the main window?

Copy link
Contributor Author

Are you talking about the Connect to Server dialog?
I've seen it work fine there.

Copy link
Contributor

bear101 commented Jan 11, 2026

You drag and drop a .tt-file from Windows Explorer onto TeamTalk's main window using the mouse.

Copy link
Contributor Author

You drag and drop a .tt-file from Windows Explorer onto TeamTalk's main window using the mouse.

I'm a screen reader user and I tried copying and pasting, but it didn't work.

Can you test yourself if possible?

Copy link
Contributor Author

You drag and drop a .tt-file from Windows Explorer onto TeamTalk's main window using the mouse.

@bear101, It seems to be working fine. Can you please check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bear101 bear101 bear101 requested changes

Copilot code review Copilot Copilot left review comments

@CoBC CoBC Awaiting requested review from CoBC CoBC is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /