Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add timeout parameter for downloading #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
an920107 wants to merge 2 commits into Baseflow:develop
base: develop
Choose a base branch
Loading
from an920107:feature/timeout

Conversation

@an920107
Copy link

@an920107 an920107 commented Feb 19, 2025
edited
Loading

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

This PR is to resolve #141, supporting pass timeout for downloading.

⤵️ What is the current behavior?

There is no way to set timeout.

🆕 What is the new behavior (if this is a feature change)?

A timeout duration can be set, and the http request will be timeouted after the duration (a TimeoutException will be thrown). If timeout is not set, all behaviors are same with the original.

💥 Does this PR introduce a breaking change?

N/A

🐛 Recommendations for testing

  1. Check if it will stop and throw a TimeoutException after the duration.
  2. Check if the behavior is same as original when timeout is not set.

📝 Links to relevant issues/docs

Issue #141.

🤔 Checklist before submitting

  • All projects build
  • Follows style guide lines (code style guide)
  • Relevant documentation was updated
  • Rebased onto current develop

@an920107 an920107 marked this pull request as ready for review February 19, 2025 04:04
Copy link

Gustl22 commented Aug 6, 2025
edited
Loading

@martijn00 can we have this reviewed? Thans for the time effort :D
Or is this already possible through intercepting dio / http service?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

a way to setup the request timeout

2 participants

AltStyle によって変換されたページ (->オリジナル) /