-
-
Notifications
You must be signed in to change notification settings - Fork 35
added namespace for AGP8 compatibility #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@JeroenWeener could you please take a look at this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
Could you add the namespace property to the example gradle file as well (without the if-statement)?
Before we merge, could you update the CHANGELOG and pubspec.yaml?
TheHypnoo
commented
May 23, 2023
@deckerst Hi, could you move forward with this PR? Thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, modules a small nit would be great if you'd be able to send a small update for that.
Co-authored-by: Maurits van Beusekom <maurits@baseflow.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks again for your contribution!
TheHypnoo
commented
May 26, 2023
Could this be mergeable? Thank you! @JeroenWeener @mvanbeusekom
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
adding namespace in
build.gradlefor compatibility with AGP 8no behaviour change
🆕 What is the new behavior (if this is a feature change)?
no behaviour change
💥 Does this PR introduce a breaking change?
no
🐛 Recommendations for testing
use AGP 8
📝 Links to relevant issues/docs
cf Flutter packages comment/solution:
🤔 Checklist before submitting